On Tue, 29 May 2012 15:51:47 -0700, "Ian Romanick" <i...@freedesktop.org> wrote:
> +TEST(GetProcAddress, ABINameByOffset)
> +{
> +   /* 408 functions have had their locations in the dispatch table set since
> +    * the danw of time.  Verify that all of these functions are at the 
> correct
             ^dawn

(also copy and pasted)

I don't like the "as big as at some git sha1" test given that you
immediately go on to show that the test is invalid and just hack around
it.  That sounds to me like "this test should be removed".  Maybe just
check that it's bigger than the fixed ABI?

Attachment: pgpPa7UYi8RD8.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to