> +        if (!supported_gpu) {
> +                fprintf(stderr, "Unsupported GPU\n");
> +                free(screen);
> +                return NULL;
> +        }

End users may see this. Is it better to silently fail or to print a
message that Panfrost isn't loaded (either way, the swrast would
probably load in its place).

> +static const panfrost_supported_gpus[] = {
> +        0x0750,
> +        0x0820,
> +        0x0860
> +};

Please add a comment to each line with the commercial name of the
respective GPU. (e.g. "/* Mali T760 */")

Attachment: signature.asc
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to