On Fri, Jun 21, 2019 at 1:13 PM Emil Velikov <emil.l.veli...@gmail.com> wrote:
> From: Emil Velikov <emil.veli...@collabora.com> > > Currently libdrm_amdgpu provides a typedef of the various handles. While > the goal was to make those opaque, it effectively became part of the API > > To the best of my knowledge there are two ways to have opaque handles: > - "typedef void *foo;" - rather messy IMHO > - "stuct foo;" and use "struct foo *" through the API > > In our case amdgpU_device_handle is used only internally, plus > respective code is not used or applicable for r300 and r600. Hence we > copied the typedef. > > Seemingly this will be a problem since a libdrm_amdgpu wants to change > the API, while not updating the code(?). > libdrm_amdgpu can't change the API. Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
