Why do you need to call it in a loop? On Mon, Jun 17, 2019 at 5:21 AM Boris Brezillon < boris.brezil...@collabora.com> wrote:
> Hello, > > I've recently been working on adding a new lowering option to the > lower_tex() logic and found out that doing > > do progress = nir_lower_tex(); while (progress); > > is not working well (nir_lower_tex() keeps returning true and lowering > the same instructions over and over again). > > The 2 patches in this series seem to fix my issues, but I'm only using > txp and rect lowering, and looking at the rest of the code I fear there > are other places that could lower things twice of keep reporting that > things have progressed even if it's not true (yuv to rgb conversion is > of these). So, my question is, are nir_lower_tex() users supposed to > clear options flags manually after this pass and limit the number > of passes (through some experimenting) or should we try to fix > nir_lower_tex()? > > Regards, > > Boris > > Boris Brezillon (2): > nir/lower_tex: Actually report when projector lowering happened > nir/lower_tex: Update ->sampler_dim value before calling > get_texture_size() > > src/compiler/nir/nir_lower_tex.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > -- > 2.20.1 > >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
