Okay I talked to Emil last night about these, and while I'm not happy with the situation we are in, replacing one job of the generator with a new generator that does half the job, really doesn't get us anywhere, I wished we'd blocked all of this earlier in favour of replacing the generators wholesale so both sides were generated from the same code. What we have now is inherently fragile, even if what we had before might have been considered ugly.
I'm begrudingly giving a for both of these, just to unblock 19.1. Reviewed-by: Dave Airlie <airl...@redhat.com> Emil I think you should give serious consideration to unwinding all of this in master, and trying again when you can wholesale replace the generator from out XML with a generator from Khronos XML, generating two different parts of the tree from different XML isn't a solution we should ever have considered. Dave On Thu, 6 Jun 2019 at 02:24, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > From: Emil Velikov <emil.veli...@collabora.com> > > As elaborated in the next patch, there is some hidden ABI that > effectively require most entrypoints to be listed in the file. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110302 > Cc: Marek Olšák <mar...@gmail.com> > Fixes: c5c38e831ee ("mesa: implement ARB/KHR_parallel_shader_compile") > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > src/mapi/glapi/gen/static_data.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mapi/glapi/gen/static_data.py > b/src/mapi/glapi/gen/static_data.py > index bc49324348f..dc1926327da 100644 > --- a/src/mapi/glapi/gen/static_data.py > +++ b/src/mapi/glapi/gen/static_data.py > @@ -1453,6 +1453,7 @@ offsets = { > "TexParameterxv": 1417, > "BlendBarrier": 1418, > "PrimitiveBoundingBox": 1419, > + "MaxShaderCompilerThreadsKHR": 1420, > } > > functions = [ > -- > 2.20.1 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
