On Fri, 2019-05-31 at 14:55 +0200, Connor Abbott wrote:
> Bindless handles in GL are 64-bit. This fixes an assert failure in LLVM.
Does it make sense to nominate this for stable release?
J.A.
> ---
>
> With this patch, we now have Piglit parity in debug mode.
>
> src/gallium/drivers/radeonsi/si_shader_nir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c
> b/src/gallium/drivers/radeonsi/si_shader_nir.c
> index 19ed71ae05d..72e6ffbac8a 100644
> --- a/src/gallium/drivers/radeonsi/si_shader_nir.c
> +++ b/src/gallium/drivers/radeonsi/si_shader_nir.c
> @@ -1020,7 +1020,7 @@ si_nir_load_sampler_desc(struct ac_shader_abi *abi,
> * 16-dword slots for now.
> */
> dynamic_index = LLVMBuildMul(ctx->ac.builder,
> dynamic_index,
> - LLVMConstInt(ctx->i32, 2, 0), "");
> + LLVMConstInt(ctx->i64, 2, 0), "");
>
> return si_load_image_desc(ctx, list, dynamic_index,
> desc_type,
> dcc_off, true);
> @@ -1032,7 +1032,7 @@ si_nir_load_sampler_desc(struct ac_shader_abi *abi,
> * to prevent incorrect code generation and hangs.
> */
> dynamic_index = LLVMBuildMul(ctx->ac.builder, dynamic_index,
> - LLVMConstInt(ctx->i32, 2, 0), "");
> + LLVMConstInt(ctx->i64, 2, 0), "");
> list = ac_build_pointer_add(&ctx->ac, list, dynamic_index);
> return si_load_sampler_desc(ctx, list, ctx->i32_0, desc_type);
> }
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
