So you prefer to use the nir sysval method and implement a per driver version of viewport transform? As I sended out a patch series for a shared version of this transform, any feedback on it? https://patchwork.freedesktop.org/series/58618/
Regards, Qiang On Wed, Apr 3, 2019 at 9:50 AM Alyssa Rosenzweig <aly...@rosenzweig.io> wrote: > > This patch set implements the infrastructure for piping system values > through Panfrost, replacing the prior brittle system of magic uniform > offsets. This infrastructure is used to implement the vertex shader > viewport transformation, which will soon be shared with lima. > > Alyssa Rosenzweig (2): > nir: Add "viewport vector" system values > panfrost: Implement system values > > src/compiler/nir/nir_intrinsics.py | 5 + > src/gallium/drivers/panfrost/meson.build | 1 + > .../drivers/panfrost/midgard/helpers.h | 4 - > .../panfrost/midgard/midgard_compile.c | 272 +++++++++--------- > .../panfrost/midgard/midgard_compile.h | 27 +- > src/gallium/drivers/panfrost/pan_assemble.c | 5 + > src/gallium/drivers/panfrost/pan_context.c | 103 +++---- > src/gallium/drivers/panfrost/pan_context.h | 5 + > 8 files changed, 234 insertions(+), 188 deletions(-) > > -- > 2.20.1 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
