> + if (!screen->driver->create_perfcnt_query)
> + return NULL;
Redundant -- it'll always be set since there's only DRM driver now. We
should probably drop the indirection wholesale, too, but that's for a
different patch. I guess if the DRM implementation isn't until next
patch, it's still probably cleanest to just squash the two and hope for
the best.
> + screen->driver->destroy_perfcnt_query)
"""
> /* We need to flush out the jobs to actually run the counter, TODO
> * check wait, TODO wallpaper after if needed */
>
> panfrost_flush(pipe, NULL, PIPE_FLUSH_END_OF_FRAME);
Does this flush apply to performance counters too?
> +static int panfrost_get_query_group_info(struct pipe_screen *screen,
> + unsigned index,
> + struct pipe_driver_query_group_info
> *info)
> +{
> + struct panfrost_screen *pscreen = pan_screen(screen);
> +
> + if (!info)
> + return 1;
Erm, semantically, what does this mean?
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
