On Tue, Mar 26, 2019 at 11:00 AM Alyssa Rosenzweig <aly...@rosenzweig.io> wrote: > > > Seems Panfrost implementation does not take depth uniforms? > > That's a /* to-do */ for me; it should definitely be implemented before > adding to common code. > > > we both use the viewport scale/transform vector as the uniform > > in this lower pass. > > I think that's reasonable. I don't like wasting a half-uniform (2vec3 = > 1.5vec4), but that can't be helped I guess. > > > But due to lima pad special uniforms instead of prefix like > > panfrost, we need to add a uniform location parameter to the API function. > > What do you mean by "pad vs prefix"? Lima pad special uniform after system uniform, but Panfrost put special uniform before the system uniform.
> A location parameter is a good idea > regardless. Better yet, we could use an intrinsic system value load (I > forget the exact) name to handle this, which I think is the most generic > way for common NIR routines. I mean a driver spec (passed in) uniform location. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
