On Wednesday, March 20, 2019 6:37:07 AM PDT Ilia Mirkin wrote: > On Wed, Mar 6, 2019 at 3:32 AM Kenneth Graunke <kenn...@whitecape.org> wrote: > > There are no nouveau changes in this patch, but that's only because none > > appeared to be necessary. Most drivers performed some kind of flush on > > any memory_barrier() call, regardless of the bits - but nouveau's hooks > > don't. So the newly added case would already be a no-op. > > I didn't go back to check the code earlier, but just saw the pushed > patch, forgot this comment, and decided to check. Looks like > > https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nvc0/nvc0_context.c#n90 > > would get executed, no? > > -ilia
Yikes...apparently failed at reading. I pushed a quick fix with the same code to bail that I put in all the other drivers: https://cgit.freedesktop.org/mesa/mesa/commit/?id=3c3f250456623d9892042a6d296e77d359702add I also re-checked nv50 and it seemed fine. Thanks! --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
