On Mon, Jan 14, 2019 at 4:36 AM Daniel Stone <dan...@fooishbar.org> wrote:
>
> Hi,
>
> On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand <ja...@jlekstrand.net> wrote:
> > 5. There's no way with gitlab for Reviewed-by tags to get automatically
> > applied as part of the merging process. This makes merging a bit more
> > manual than it needs to be but is really no worse than it was before.
>
> I'm still on the side of not seeing the value in them.
Reviewed-by tags are useful for measuring the quantity of patch review
people do (which is useful in a corporate environment...). It's often
a thankless task that's valued much lower than first order
contributions, so having a way to at least quantify patch reviews
shows that people are spending their time to help others contribute.
The number of R-b tags is not a 100% accurate picture of the
situation, but it gives at least a good overview of who is doing the
tedious work of patch review. For instance, in 2018 the top reviewers
are
620 Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
530 Marek Olšák <marek.ol...@amd.com>
505 Jason Ekstrand <jason.ekstr...@intel.com>
452 Kenneth Graunke <kenn...@whitecape.org>
If my name were in there, it would definitely be something I put on my
yearly review.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
