On 05/09/2012 12:52 PM, Kenneth Graunke wrote: > From: Bryan Henderson <[email protected]> > > [v2/Kayden: rebased version of Bryan's original patch from: > https://bugs.freedesktop.org/show_bug.cgi?id=33447] > > Cc: Jeremy Huddleston <[email protected]> > Cc: Chad Versace <[email protected]> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33447 > Signed-off-by: Kenneth Graunke <[email protected]> > --- > src/glsl/strtod.c | 11 +++++++---- > src/mesa/main/imports.c | 22 +++++++++++++++++----- > 2 files changed, 24 insertions(+), 9 deletions(-)
> Chad: Why do we have !ANDROID for strtof_l but not strtod_l? Oversight? > Or does it actually support strtod_l? Android does not have strtod_l. Yet, the old co de successfully compiled because Android does not define _GNU_SOURCE. As is, this patch breaks the Android build because Android does define __GLIBC__ when building host binaries, such as the builtin compiler. To fix it, the #if condition in strtod.c needs !defined(ANDROID). Thanks for taking precautions to not break the Android build. ---- Chad Versace [email protected] _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
