On Tue, Dec 11, 2018 at 3:33 AM Emil Velikov <emil.l.veli...@gmail.com> wrote: > > On Mon, 10 Dec 2018 at 18:56, Kristian Høgsberg <hoegsb...@gmail.com> wrote: > > > > On Mon, Dec 10, 2018 at 7:38 AM Emil Velikov <emil.l.veli...@gmail.com> > > wrote: > > > > > > On Fri, 7 Dec 2018 at 23:48, Kristian H. Kristensen <hoegsb...@gmail.com> > > > wrote: > > > > > > > > --- > > > > src/mapi/glapi/gen/EXT_multisampled_render_to_texture.xml | 2 +- > > > > src/mapi/glapi/gen/es_EXT.xml | 2 ++ > > > > src/mapi/glapi/gen/gl_API.xml | 2 -- > > > > src/mesa/main/tests/dispatch_sanity.cpp | 3 +++ > > > > 4 files changed, 6 insertions(+), 3 deletions(-) > > > > > > > There's a bit more to it. I'm testing something up and will send a > > > patch shortly. > > > > You could also just review this patch and tell me what's missing. > > Either way, we need to fix the test suite, so let's close this soon. > > I'll commit this end of today if I don't hear from you. > > > As you can see in v2 - tracking down exactly what works and is > reasonable took quite a bit. > Fwiw I've kept you as the patch author, although I feel that's not > your main concern.
No, I'm not to worried about that, I just don't feel good about the "let me rewrite your patch for you" style of review. But I appreciate your help in this case, thanks. Kristian > > HTH > -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
