Quoting Eric Engestrom (2018-12-03 10:26:01) > On Monday, 2018-12-03 10:06:30 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-12-03 09:46:29) > > > On Monday, 2018-12-03 09:25:48 -0800, Dylan Baker wrote: > > > > Can I admit I was really wanted to send this patch out and it actually > > > > makes me > > > > sad that you beat me too it? > > > > > > Heh, I think many (most?) of us wanted to send this patch :P > > > > > > > > > > > That said there are a couple things you missed. > > > > > > I think you forgot to mention what those things are? > > > > > > If you prefer, feel free to just compare your patch and mine and just > > > add anything you might have missed and send out yours as the v2 of mine. > > > Note that Anholt gave some feedback which I applied locally, in case it > > > applies to you too :) > > > > What I saw diffing them is that I did get the travis jobs, but didn't get > > the > > .gitignore files. I also wrote a little script and found the > > Makefile.sources > > files that are used only by autotools (not scons or android), which I think > > was > > the bulk of what you missed. > > > > I went ahead and sent out a v2 with a heartfelt plea :) > > I don't seem to have received it... It might have been too big and got > caught in moderation? > If you haven't, you should use --irreversible-delete to not show the > diff of files deleted, as I did (and my email was already 60KB!)
I had no idea that --irreversible-delete existed! Resent using that (and with the stray change removed) Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
