On Tue, Nov 27, 2018 at 9:17 PM Ilia Mirkin <imir...@alum.mit.edu> wrote:
> On Tue, Nov 27, 2018 at 9:00 PM Marek Olšák <mar...@gmail.com> wrote: > > > > From: Marek Olšák <marek.ol...@amd.com> > > > > For format fallbacks like ETC and ASTC, switching between sRGB and linear > > decoding is undefined, or at least is not bit-exact. Same as > > EXT_texture_sRGB_decode on GLES. > > > > There are no piglit or dEQP regresssions. > > Just checking -- did you run dEQP on hardware that uses the ASTC > fallbacks? If not, could you? > radeonsi doesn't support ASTC, so I always use the fallback. Like I said, no regressions in newly enabled tests. > > Also, what are the conditions for enabling ASTC fallbacks? Basically > the issue is that OES_texture_view requires ASTC, so I want to make > sure it'll be enabled for any drivers that > PIPE_CAP_SAMPLER_VIEW_TARGET is enabled for. > ASTC is always enabled. The existing behavior being talked about is already exposed by EXT_texture_sRGB_decode on GLES. The extension only adds another way to access that behavior. I'm open to discussing how to make EXT_texture_sRGB_decode bit-exact for compressed format fallbacks. I may also let it slide if test suites don't care. Marek
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
