On Sun, Apr 29, 2012 at 4:03 AM, Olivier Galibert <galib...@pobox.com> wrote: > Hi, > > Is there any (sane?) reason why the defines in p_shader_tokens aren't > enums, at least most of them? The tgsi opcodes aren't an exported > interface, right? Right?
We probably could use enums in more places. One minor issue I seem to remember is assigning an enum value into a bitfield (which we use a lot in tgsi) can cause compiler warnings. But I'd have to double-check that. I prefer not seeing a slew of new warnings because it's easy to miss other important warnings in the midst of that. -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
