On Friday, 2018-11-09 13:28:49 -0800, Dylan Baker wrote: > meson does this for you with it's warn levels, so we don't need to set > it ourselves.
s/it's/its/ And yeah you're right, I just checked and -Wall (or equivalent) is always passed to compilers that support it. Reviewed-by: Eric Engestrom <eric.engest...@intel.com> > > Fixes: d1992255bb29054fa51763376d125183a9f602f3 > ("meson: Add build Intel "anv" vulkan driver") > --- > meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 18667988bac..dabfb9abddd 100644 > --- a/meson.build > +++ b/meson.build > @@ -787,7 +787,7 @@ endif > > # Check for generic C arguments > c_args = [] > -foreach a : ['-Wall', '-Werror=implicit-function-declaration', > +foreach a : ['-Werror=implicit-function-declaration', > '-Werror=missing-prototypes', '-Werror=return-type', > '-fno-math-errno', > '-fno-trapping-math', '-Qunused-arguments'] > @@ -809,7 +809,7 @@ endif > > # Check for generic C++ arguments > cpp_args = [] > -foreach a : ['-Wall', '-Werror=return-type', > +foreach a : ['-Werror=return-type', > '-fno-math-errno', '-fno-trapping-math', > '-Qunused-arguments'] > if cpp.has_argument(a) > -- > 2.19.1 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev