On Thu, 8 Nov 2018 at 12:20, Juan A. Suarez Romero <jasua...@igalia.com> wrote:
>
> On Wed, 2018-11-07 at 12:07 +0000, Emil Velikov wrote:
> > From: Emil Velikov <emil.veli...@collabora.com>
> >
> > With later commits we'll fold all the different scripts into one.
> > Add the explicit prefix, so that we know the origin of the nomination
> >
> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
> > ---
> > bin/get-pick-list.sh | 21 ++++++++++++++++++++-
> > 1 file changed, 20 insertions(+), 1 deletion(-)
> >
> > diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> > index ba741cc4114..33a8a4cba48 100755
> > --- a/bin/get-pick-list.sh
> > +++ b/bin/get-pick-list.sh
> > @@ -7,6 +7,15 @@
> > # $ bin/get-pick-list.sh
> > # $ bin/get-pick-list.sh > picklist
> > # $ bin/get-pick-list.sh | tee picklist
> > +#
> > +# The output is as follows:
> > +# [nominaiton_type] commit_sha commit summary
> > +
> > +is_stable_nomination()
> > +{
> > + stable=`git show --summary $sha | grep -i -o "CC:.*mesa-stable"`
> > + return $?
> > +}
> >
> > # Use the last branchpoint as our limit for the search
> > latest_branchpoint=`git merge-base origin/master HEAD`
> > @@ -32,7 +41,17 @@ do
> > continue
> > fi
> >
> > - git --no-pager show --summary --oneline $sha
> > + tag=none
> > + if is_stable_nomination; then
> > + tag=stable
> > + fi
> > +
> > + if test tag = none; then
> > + continue
> > + fi
>
> This last condition is not working correctly on my system. Anyway, I'd merge
> it
> with the first one:
>
> if is_stable_nomination; then
> tag=stable
> else
> continue
> fi
>
That's due to the missing $ in tag = none. That aside, explicit else
works for me.
v2 - with a handful of extra patches coming in a moment.
Thanks
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
