This is still waiting for a review. Iago
On Wed, 2018-10-31 at 12:18 +0100, Iago Toral Quiroga wrote: > nir_alu_type_get_type_size takes a type as parameter and we were > passing a bit-size instead, which did what we wanted by accident, > since a bit-size of zero matches nir_type_invalid, which has a > size of 0 too. > --- > src/compiler/nir/nir_opt_constant_folding.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_constant_folding.c > b/src/compiler/nir/nir_opt_constant_folding.c > index e5ec5e9583f..c91e7e16855 100644 > --- a/src/compiler/nir/nir_opt_constant_folding.c > +++ b/src/compiler/nir/nir_opt_constant_folding.c > @@ -63,10 +63,8 @@ constant_fold_alu_instr(nir_alu_instr *instr, void > *mem_ctx) > if (!instr->src[i].src.is_ssa) > return false; > > - if (bit_size == 0 && > - !nir_alu_type_get_type_size(nir_op_infos[instr- > >op].input_sizes[i])) { > + if (bit_size == 0 && nir_op_infos[instr->op].input_sizes[i] == > 0) > bit_size = instr->src[i].src.ssa->bit_size; > - } > > nir_instr *src_instr = instr->src[i].src.ssa->parent_instr; > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev