FYI there's a whole lot of tests that start to fail when this series
running on Intel CI. It includes dEQP but also Piglit tests, can you do
Intel CI run or do you want me to send you results?
// Tapani
On 11/7/18 5:58 PM, Erik Faye-Lund wrote:
Here's a bunch of patches for missing error generation in the query
buffer code.
The general pattern, is that code that directly checks
ctx->Extensions.FOO_bar instead of using _mesa_has_FOO_bar(ctx) will
often end up drawing the wrong conclusion on ES, because the flag in
ctx->Extensions only tells us that the *driver* supports this, not
the target-API.
This was noticed when porting the NV_conditional_rendering piglit tests
to ES 2, where the observation was that using GL_SAMPLES_PASSED worked
in ES 3, but not when run on ES 2.
Some other related issues that was noticed while fixing this are also
included.
Erik Faye-Lund (13):
mesa/main: correct requirement for EXT_occlusion_query_boolean
mesa/main: correct year for EXT_occlusion_query_boolean
mesa/main: use non-prefixed enums for consistency
mesa/main: simplify pipeline-statistics query validation
mesa/main: fix validation of GL_SAMPLES_PASSED
mesa/main: fix validation of GL_ANY_SAMPLES_PASSED
mesa/main: fix validation of GL_ANY_SAMPLES_PASSED_CONSERVATIVE
mesa/main: fix validation of GL_TIME_ELAPSED
mesa/main: fix validation of transform-feedback queries
mesa/main: fix validation of transform-feedback overflow queries
mesa/main: fix validation of ARB_query_buffer_object
mesa/main: fix validation of GL_TIMESTAMP
mesa/main: remove overly strict query-validation
src/mesa/main/extensions_table.h | 2 +-
src/mesa/main/queryobj.c | 108 ++++++++++++++-----------------
2 files changed, 48 insertions(+), 62 deletions(-)
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
