On Wed, 31 Oct 2018 at 18:20, Eric Engestrom <eric.engest...@intel.com> wrote:
>
> On Wednesday, 2018-10-31 10:15:40 -0700, Dylan Baker wrote:
> > gtest doesn't generate any warnings, but this seems fine,
>
> It does for me, because I have more warnings enabled locally :P
>
Nothing special enabled here, gtest is fairly unhappy.

> One that I'd like to eventually enable (and as an error if possible)
> is -Wundef to warn when undefined macros are used; in my experience at
> $PREVIOUS_JOB this warning very often indicates actual bugs.
>
It would have caught a bug in Mesa as well. +1 on the idea to Werror=undef

> > Reviewed-by: Dylan Baker <dy...@pnwbakers.com>
>
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>

-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to