On 10/16/18 9:54 AM, Bas Nieuwenhuizen wrote:
On Tue, Oct 16, 2018 at 9:40 AM Samuel Pitoiset
<samuel.pitoi...@gmail.com> wrote:

This feature isn't used for now, so disable it until
wwm is fixed in LLVM.

Is wwm actually the issue?

Just reporting what Daniel said.


Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>

Fixes dEQP-VK.subgroups.vote.graphics.subgroupallequal*

https://bugs.freedesktop.org/show_bug.cgi?id=108115
Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
---
  src/amd/vulkan/radv_device.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 174922780f..5fd5d48c42 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1057,12 +1057,14 @@ void radv_GetPhysicalDeviceProperties2(
                             (VkPhysicalDeviceSubgroupProperties*)ext;
                         properties->subgroupSize = 64;
                         properties->supportedStages = VK_SHADER_STAGE_ALL;
+                       /* TODO: Enable VK_SUBGROUP_FEATURE_VOTE_BIT when wwm
+                        * is fixed in LLLVM.
+                        */
                         properties->supportedOperations =
                                                         
VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |
                                                         
VK_SUBGROUP_FEATURE_BASIC_BIT |
                                                         
VK_SUBGROUP_FEATURE_BALLOT_BIT |
-                                                       
VK_SUBGROUP_FEATURE_QUAD_BIT |
-                                                       
VK_SUBGROUP_FEATURE_VOTE_BIT;
+                                                       
VK_SUBGROUP_FEATURE_QUAD_BIT;
                         if (pdevice->rad_info.chip_class >= VI) {
                                 properties->supportedOperations |=
                                                         
VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
--
2.19.1

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to