Am Donnerstag, den 04.10.2018, 10:48 -0700 schrieb Gurchetan Singh: > > The idea is to get rid of any adjustments on both the Mesa / > virglrenderer sides -- so transfer size is just what's needed to > transfer the box size, and the offset is the just offset into the > iovec from which the transfer will start. For v1, we can just > specify an offset of zero on the virglrenderer side.
I certainly see you point, the problem is (as Tomeu also pointed out) we would like to enable the CI *now*, and all what is missing is this patch. If we want to correct the protocol it will likely take another couple of weeks to get it right and do all the testing, and this while facing the more challanging changes regarding memory handling, adding more GL extensions etc. > vtest isn't used in production but it will be used in the CI. Also, > it's a simpler model of virgl3d and is useful for experimenting with > new protocol additions (hostmap, vulkan). We should fix this now -- > it could take a while to disentangle the workarounds should anyone > look at this again ... My proposal to unblock this would be open an issue against virglrenderer (because the problem is on both sides) and doeument there where the problems are. Whether this gets fixed by correcting this code, or completely replacing things (like Tomeu proposed) is another story. What do you think? Gert _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
