On Wed, Oct 3, 2018 at 9:17 PM Jason Ekstrand <ja...@jlekstrand.net> wrote: > > The ssa_for_alu_src helper will correctly handle swizzles and other > source modifiers for you. The expansions for unpack_half_2x16, > pack_uvec2_to_uint, and pack_uvec4_to_uint were all broken with regards > to swizzles. The brokenness of unpack_half_2x16 was causing rendering > errors in Rise of the Tomb Raider on Intel ever since c11833ab24dcba26 > which added an extra copy propagation to the optimization pipeline and > caused us to start seeing swizzles where we hadn't seen any before. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107926 > Fixes: 9ce901058f3d "nir: Add lowering of nir_op_unpack_half_2x16." > Fixes: 9b8786eba955 "nir: Add lowering support for packing opcodes." > Cc: Alex Smith <asm...@feralinteractive.com> > Cc: Matt Turner <matts...@gmail.com> > --- > src/compiler/nir/nir_lower_alu_to_scalar.c | 33 ++++++++++++---------- > 1 file changed, 18 insertions(+), 15 deletions(-)
Fixes a regression I've noticed in one of our D3D12 to Vulkan translation samples. Thanks! Tested-by: Józef Kucia <joseph.ku...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
