Wow...

I was hoping to find a warning about this in coverity, but it doesn't seem to...

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>

On 02/10/2018 03:23, Jason Ekstrand wrote:
This fixes a bunch of Vulkan subgroup tests on little core platforms.

Fixes: 4150920b95 "intel/fs: Add a helper for emitting scan operations"
---
  src/intel/compiler/brw_fs_builder.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/compiler/brw_fs_builder.h 
b/src/intel/compiler/brw_fs_builder.h
index 7bee2aa0b9b..0cafaf50e56 100644
--- a/src/intel/compiler/brw_fs_builder.h
+++ b/src/intel/compiler/brw_fs_builder.h
@@ -795,7 +795,7 @@ namespace brw {
               !gen_device_info_is_9lp(shader->devinfo))
              return false;
- if (type_sz(type > 4))
+         if (type_sz(type) > 4)
              return true;
if (opcode == BRW_OPCODE_MUL &&


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to