Please add a comment that UGE is used because NaN means no kill. Thanks. You can also nominate this for stable. Other than those:
Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Sun, Sep 23, 2018 at 1:00 PM, Axel Davy <davyax...@gmail.com> wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=105333 > Fixes: https://github.com/iXit/Mesa-3D/issues/314 > > For this application, NaN is passed to KILL_IF and is expected to > pass. > > Signed-off-by: Axel Davy <davyax...@gmail.com> > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c > b/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c > index f54d025aec0..3469ad9ca67 100644 > --- a/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c > +++ b/src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c > @@ -60,7 +60,7 @@ static void kil_emit(const struct lp_build_tgsi_action > *action, > > for (i = 0; i < TGSI_NUM_CHANNELS; i++) { > LLVMValueRef value = lp_build_emit_fetch(bld_base, > inst, 0, i); > - conds[i] = LLVMBuildFCmp(builder, LLVMRealOGE, value, > + conds[i] = LLVMBuildFCmp(builder, LLVMRealUGE, value, > ctx->ac.f32_0, ""); > } > > -- > 2.18.0 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
