On 6 September 2018 at 15:47, Eric Engestrom <eric.engest...@intel.com> wrote: > The current minimum meson version supported is 0.44.1, so we have met > both the 0.43 and 0.44 requirement to not need these hacks anymore :) > Yes, please.
Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > Signed-off-by: Eric Engestrom <eric.engest...@intel.com> > --- > meson.build | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/meson.build b/meson.build > index ae30efbfa4fdcd7c7492..9c0ae3469d4f9d0bb076 100644 > --- a/meson.build > +++ b/meson.build > @@ -1204,10 +1204,6 @@ else > endif > if with_llvm > _llvm_version = dep_llvm.version().split('.') > - # Development versions of LLVM have an 'svn' or 'git' suffix, we don't want > - # that for our version checks. > - # svn suffixes are stripped by meson as of 0.43, and git suffixes are > - # strippped as of 0.44, but we support older meson versions. > > # 3 digits versions in LLVM only started from 3.4.1 on > if dep_llvm.version().version_compare('>= 3.4.1') Seemingly the VMWare people have transitioned to LLVM 5.0.1 so I'll send out some patches to bump+nuke this hack ;-) -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev