Re: [Mesa-dev] [PATCH 2/3] intel: Introducing Amber Lake platform

[Lionel Landwerlin]

On 30/08/2018 22:41, Rodrigo Vivi wrote:

Amber Lake uses the same gen graphics as Kaby Lake, including a id
that were previously marked as reserved on Kaby Lake, but that
now is moved to AML page.

This follows the ids and approach used on kernel's commit
e364672477a1 ("drm/i915/aml: Introducing Amber Lake platform")

Reported-by: Timo Aaltonen <timo.aalto...@canonical.com>
Cc: José Roberto de Souza <jose.so...@intel.com>
Cc: Anuj Phogat <anuj.pho...@gmail.com>
Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com>

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>

---
  include/pci_ids/i965_pci_ids.h          | 3 ++-
  src/intel/compiler/test_eu_validate.cpp | 1 +
  src/intel/dev/gen_device_info.c         | 1 +
  src/intel/tools/aubinator.c             | 2 +-
  4 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h
index bced44e288..4efac638e9 100644
--- a/include/pci_ids/i965_pci_ids.h
+++ b/include/pci_ids/i965_pci_ids.h
@@ -156,7 +156,6 @@ CHIPSET(0x5912, kbl_gt2, "Intel(R) HD Graphics 630 (Kaby Lake 
GT2)")
  CHIPSET(0x5916, kbl_gt2, "Intel(R) HD Graphics 620 (Kaby Lake GT2)")
  CHIPSET(0x591A, kbl_gt2, "Intel(R) HD Graphics P630 (Kaby Lake GT2)")
  CHIPSET(0x591B, kbl_gt2, "Intel(R) HD Graphics 630 (Kaby Lake GT2)")
-CHIPSET(0x591C, kbl_gt2, "Intel(R) Kaby Lake GT2")
  CHIPSET(0x591D, kbl_gt2, "Intel(R) HD Graphics P630 (Kaby Lake GT2)")
  CHIPSET(0x591E, kbl_gt2, "Intel(R) HD Graphics 615 (Kaby Lake GT2)")
  CHIPSET(0x5921, kbl_gt2, "Intel(R) Kabylake GT2F")
@@ -164,6 +163,8 @@ CHIPSET(0x5923, kbl_gt3, "Intel(R) Kabylake GT3")
  CHIPSET(0x5926, kbl_gt3, "Intel(R) Iris Plus Graphics 640 (Kaby Lake GT3e)")
  CHIPSET(0x5927, kbl_gt3, "Intel(R) Iris Plus Graphics 650 (Kaby Lake GT3e)")
  CHIPSET(0x593B, kbl_gt4, "Intel(R) Kabylake GT4")
+CHIPSET(0x591C, kbl_gt2, "Intel(R) Amber Lake GT2")
+CHIPSET(0x87C0, kbl_gt2, "Intel(R) Amber Lake GT2")
  CHIPSET(0x3184, glk,     "Intel(R) UHD Graphics 605 (Geminilake)")
  CHIPSET(0x3185, glk_2x6, "Intel(R) UHD Graphics 600 (Geminilake 2x6)")
  CHIPSET(0x3E90, cfl_gt1, "Intel(R) UHD Graphics 610 (Coffeelake 2x6 GT1)")
diff --git a/src/intel/compiler/test_eu_validate.cpp 
b/src/intel/compiler/test_eu_validate.cpp
index b132b87a1a..744ae5806d 100644
--- a/src/intel/compiler/test_eu_validate.cpp
+++ b/src/intel/compiler/test_eu_validate.cpp
@@ -40,6 +40,7 @@ static const struct gen_info {
     { "skl", },
     { "bxt", },
     { "kbl", },
+   { "aml", },
     { "glk", },
     { "cfl", },
     { "cnl", },
diff --git a/src/intel/dev/gen_device_info.c b/src/intel/dev/gen_device_info.c
index b0ae4d1803..3cece52a04 100644
--- a/src/intel/dev/gen_device_info.c
+++ b/src/intel/dev/gen_device_info.c
@@ -57,6 +57,7 @@ gen_device_name_to_pci_device_id(const char *name)
        { "skl", 0x1912 },
        { "bxt", 0x5A85 },
        { "kbl", 0x5912 },
+      { "aml", 0x591C },
        { "glk", 0x3185 },
        { "cfl", 0x3E9B },
        { "cnl", 0x5a52 },
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index edd11fe0f5..55672fa073 100644
--- a/src/intel/tools/aubinator.c
+++ b/src/intel/tools/aubinator.c
@@ -282,7 +282,7 @@ int main(int argc, char *argv[])
           if (id < 0) {
              fprintf(stderr, "can't parse gen: '%s', expected brw, g4x, ilk, "
                              "snb, ivb, hsw, byt, bdw, chv, skl, bxt, kbl, "
-                            "glk, cfl, cnl, icl", optarg);
+                            "aml, glk, cfl, cnl, icl", optarg);
              exit(EXIT_FAILURE);
           } else {
              pci_id = id;

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev