I sent a minor comment on patch 6. The rest of the series is Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
On 08/21/2018 05:02 PM, Sagar Ghuge wrote: > This patch series implements AMD_depth_clamp_separate extension. > Previously I sent patches for comments and based on Ian and Marek's > suggestions, I did some changes. > > 1) Get rid of DepthClamp as DepthClampNear + DepthClampFar replaces it > (Marek Olsak & Ian Romanick) > > 2) Make sure that patch series should build at every commit (Ian > Romanick) > > 3) Change the sequence of patches (Ian Romanick) > > 4) Wrote a piglit test, in order to test the extension behavior. It is > also available as a branch on GitLab : > > https://gitlab.freedesktop.org/sagarghuge/piglit/commits/amd_depth_clamp_separate > > This series is also available as a branch on GitLab: > > https://gitlab.freedesktop.org/sagarghuge/mesa/commits/ext_amd_depth_clamp_sep > > > Sagar Ghuge (7): > glapi: define AMD_depth_clamp_separate > mesa: Add types for AMD_depth_clamp_separate. > mesa: Add support for AMD_depth_clamp_separate > mesa: add support for GL_AMD_depth_clamp_separate tokens > mesa: add EXTRA_EXT for AMD_depth_clamp_separate > i965: add functional changes for AMD_depth_clamp_separate > i965: enable AMD_depth_clamp_separate > > include/GL/glcorearb.h | 2 + > .../glapi/gen/AMD_depth_clamp_separate.xml | 15 +++++++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 3 ++ > src/mapi/glapi/gen/meson.build | 1 + > src/mesa/drivers/dri/i965/genX_state_upload.c | 34 ++++++++++---- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > src/mesa/main/attrib.c | 21 ++++++--- > src/mesa/main/enable.c | 45 +++++++++++++++++-- > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/get.c | 5 +++ > src/mesa/main/get_hash_params.py | 7 ++- > src/mesa/main/mtypes.h | 4 +- > src/mesa/main/rastpos.c | 6 ++- > src/mesa/state_tracker/st_atom_rasterizer.c | 3 +- > src/mesa/state_tracker/st_cb_drawpixels.c | 3 +- > src/mesa/swrast/s_span.c | 2 +- > src/mesa/tnl/t_vb_program.c | 6 ++- > src/mesa/tnl/t_vb_vertex.c | 8 ++-- > 19 files changed, 137 insertions(+), 31 deletions(-) > create mode 100644 src/mapi/glapi/gen/AMD_depth_clamp_separate.xml > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
