On Tuesday, 2018-08-14 10:41:41 -0700, Dylan Baker wrote:
> With the one nit, patches 1 and 3 are:
> Reviewed-by: Dylan Baker <dy...@pnwbakers.com>
Thanks! I fixed the typo and pushed both.
>
> I'm not confident on patch 2 to give you an rb.
>
> Quoting Eric Engestrom (2018-08-14 10:24:13)
> > Signed-off-by: Eric Engestrom <eric.engest...@intel.com>
> > ---
> > bin/git_sha1_gen.py | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py
> > index bcc29de1c6218ab3af79..dd967a7ee2b654c1ab92 100755
> > --- a/bin/git_sha1_gen.py
> > +++ b/bin/git_sha1_gen.py
> > @@ -42,14 +42,14 @@ def write_if_different(contents):
> >
> > parser = argparse.ArgumentParser()
> > parser.add_argument('--output', help='File to write the #define in',
> > - required=True)
> > + required=True)
> > args = parser.parse_args()
> >
> > git_sha1 = os.environ.get('MESA_GIT_SHA1_OVERRIDE', get_git_sha1())[:10]
> > if git_sha1:
> > git_sha1_h_in_path = os.path.join(os.path.dirname(sys.argv[0]),
> > - '..', 'src', 'git_sha1.h.in')
> > - with open(git_sha1_h_in_path , 'r') as git_sha1_h_in:
> > + '..', 'src', 'git_sha1.h.in')
> > + with open(git_sha1_h_in_path, 'r') as git_sha1_h_in:
> > new_sha1 = git_sha1_h_in.read().replace('@VCS_TAG@', git_sha1)
> > write_if_different(new_sha1)
> > else:
> > --
> > Cheers,
> > Eric
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
