Quoting Emil Velikov (2018-07-24 08:56:55) > On 24 July 2018 at 11:29, Eric Engestrom <eric.engest...@intel.com> wrote: > > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: > >> Until now, the needed bits were wrongly included in linux/memfd.h > >> > >> Since Travis' sys/syscall.h doesn't provide the SYS_memfd_create, we > The definition has moved across libc versions. Initially it was in > memfd.h these days it's in bits/syscall.h > > > Isn't this a matter of libc version? Isn't the right fix to upgrade the > > libc in the container instead of faking its files? > > > Last time I've looked either a) updated package wasn't available or b) > it required sudo true (no more container, bring the VM) > > > And if the libc required is quite recent, what we need is a fallback in > > the code to support older libc (possibly with some features missing), > > which this build failure rightly reports. > > > Keep in mind that Travis uses Ubuntu Trusty, which isn't really a user > of mesa-git and nearly EOL. > Since this is a build testing only, I would stick with the "build > everything" mindset and vote in favour of this workaround. > > Please change the Fixes tag to 3228335b55c - the first user of > syscall.h. With that > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > > -Emil
I prefer this approach as well as a short term fix. Perhaps a better long term solution would be to build our own docker image that contains a more realistic set of minimum versions for building current mesa than a 4 year old LTS (we could build off of 16.04 for example). Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
