On Sat, Jul 21, 2018, 05:45 Gert Wollny <gert.wol...@collabora.com> wrote:
> Am Freitag, den 20.07.2018, 12:31 -0400 schrieb Ilia Mirkin: > > > > > + /* Allow 3-comp 32 bit texturs only for TBOs (needed for > > > ARB_tbo_rgb32) */ > > > + if ((format == PIPE_FORMAT_R32G32B32_FLOAT || > > > + format == PIPE_FORMAT_R32G32B32_SINT || > > > + format == PIPE_FORMAT_R32G32B32_UINT) && > > > + target != PIPE_BUFFER) > > > + return FALSE; > > > > My personal recommendation would be to disallow *all* packed RGB > > formats unless target == PIPE_BUFFER. (And even then -- questionable, > > except for RGB32, which is required.) > > > RGB8 and RGB16 are disabled/replaced by RGBX* on the host side, and > R11G11B10 doesn't seem to make problems. > No other driver supports these. What happens on the host side is hidden from virgl. You're just signing yourself up for weird issues down the line. > but thanks for the feedback anyway, > Gert >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
