On Tue, Jul 17, 2018 at 08:21:10AM -0600, Brian Paul wrote:
> On 07/17/2018 07:31 AM, Stefan Dirsch wrote:
> > GLAPI doesn't have an 'extern' in some circumstances. This way,
> > variable declarations become definitions (fdo #100916).
> >
> > Signed-off-by: Stefan Dirsch <sndir...@suse.de>
> > ---
> > GLwDrawA.h | 12 ++++++++++--
> > GLwDrawAP.h | 4 ++--
> > 2 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/GLwDrawA.h b/GLwDrawA.h
> > index b9711c2..21f70e7 100644
> > --- a/GLwDrawA.h
> > +++ b/GLwDrawA.h
> > @@ -131,12 +131,20 @@
> > #define GLwNaccumAlphaSize "accumAlphaSize"
> > #define GLwCAccumAlphaSize "AccumAlphaSize"
> > +#if (defined(__GNUC__) && __GNUC__ >= 4) || (defined(__SUNPRO_C) &&
> > (__SUNPRO_C >= 0x590))
> > +# define GLAPIVAR extern __attribute__((visibility("default")))
> > +#endif
> > +
> > +#ifndef GLAPIVAR
> > +#define GLAPIVAR extern
> > +#endif
>
> Couldn't you just use #else instead of #endif / #ifndef GLAPIVAR ?
Yes, of course. Just resent the patch to the list.
CU,
Stefan
Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.) SUSE LINUX GmbH
Tel: 0911-740 53 0 Maxfeldstraße 5
FAX: 0911-740 53 479 D-90409 Nürnberg
http://www.suse.de Germany
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
