On Tue, Jul 17, 2018 at 1:33 PM, Eric Anholt <e...@anholt.net> wrote: > Ilia Mirkin <imir...@alum.mit.edu> writes: > >> On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt <e...@anholt.net> wrote: >>> Ilia Mirkin <imir...@alum.mit.edu> writes: >>> >>>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a >>>> drive-by comment, not a real review, sorry] >>> >>> That doesn't respect the version overrides and such that is_version >>> handles. >> >> Under what circumstance would state->es_shader != state->is_version(0, >> 100)? I can't think of one, but perhaps I'm just insufficiently >> creative. > > So you want to replace just the 100 call and leave the !300? I guess > that would be logically equivalent, but I'm not interested in painting > the bikeshed that color.
Yes, that was my suggestion. Your code, your bikeshed color. Cheers, -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
