Hi, Il giorno lun 9 lug 2018 alle ore 09:48 Bas Nieuwenhuizen < b...@basnieuwenhuizen.nl> ha scritto:
> I'd like to nominate this for 18.1 stable releases. > Me too, but I haven't seen it picked in staging/18.1 yet Please Dylan could you have a look, in case I am supposed to do something, please let me know. Mauro > > On Mon, Jul 2, 2018 at 1:25 AM, Mauro Rossi <issor.or...@gmail.com> wrote: > > pthread types are used in some files without explicitely including > pthread.h. > > This leads to compile errors on Android 7.x nougat-x86 > > e.g. in src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h > > > > In file included from > external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c:31: > > In file included from > external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.h:32: > > external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h:52:2: > error: unknown type name 'pthread_mutex_t' > > pthread_mutex_t global_bo_list_lock; > > ^ > > 1 error generated. > > > > Including pthread.h explicitely solves the building error > > > > Signed-off-by: Mauro Rossi <issor.or...@gmail.com> > > --- > > src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h > b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h > > index d6af6052a6..40d35d557b 100644 > > --- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h > > +++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h > > @@ -33,6 +33,7 @@ > > #include "addrlib/addrinterface.h" > > #include <amdgpu.h> > > #include "util/list.h" > > +#include <pthread.h> > > > > struct radv_amdgpu_winsys { > > struct radeon_winsys base; > > -- > > 2.17.1 > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev