I didn't actually get the original email for some reason, so can't comment inline as I'm just looking it up at patchwork... But the array offset stuff (the first patch) looks completely bogus to me, array textures do not support offsets for the array index, at least not in any shader language I know of.
I'm not really sure about the 2nd patch, what exactly is the difference with the ordinary rounding and the new one? Is there just a difference for values exactly between 2 integers (e.g. 1.5 etc.)? In this case I would suspect the driver is allowed to pick either value and the test is bogus. If that's not the case, it looks like it actually needs to be one patch? You're adding the 0.5 offset in one but adjust the sampler state which probably needs to match in another? Roland Am 25.06.2018 um 07:54 schrieb Dave Airlie: > /home/airlied/devel/piglit/bin/textureGather fs nonconst r 0 float > 2DArray repeat > > amongst others appears to regress with these two. > > Dave. > > > On 22 June 2018 at 19:37, Gert Wollny <gert.wol...@collabora.com> wrote: >> these two patches correct the offets and the rounding modes for the >> index evaluation when accessing texture arrays. The patches were tested >> with the gles3 test suite where they fix a number of tests related to 2D >> texture arrays and didn't show any regressions. >> >> Best, >> Gert >> >> Gert Wollny (2): >> r600: correct texture offset for array index lookup >> r600: set rounding mode for texture array layer selection >> >> src/gallium/drivers/r600/evergreen_state.c | 21 ++++++++++ >> src/gallium/drivers/r600/r600_shader.c | 64 >> +++++++++++++++++++++++++++++- >> 2 files changed, 84 insertions(+), 1 deletion(-) >> >> -- >> 2.16.4 >> > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Csroland%40vmware.com%7C038ae632c8354209810c08d5da601219%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C1%7C636655028533194684&sdata=gvQB0DNGvaNwBN5EHlJNrXED4biq3xC4rFqNEYqS3xs%3D&reserved=0 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
