Hi Rob,
On Wed, Jun 20, 2018 at 10:26 PM Robert Foss <robert.f...@collabora.com> wrote:
>
> This patch both adds support for probing & filtering DRM nodes
> and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD
> gralloc call.
>
> Currently the filtering is based just on the driver name,
> and the desired name is supplied using the "drm.gpu.vendor_name"
> Android property.
>
> Signed-off-by: Robert Foss <robert.f...@collabora.com>
> ---
>
> Changes since v3:
> - Reduced number of probing return codes
> - Simplified driver vendor check in droid_probe_device()
> - Fixed type with ';' prepended to a if-statement
> - Removed a strlen call
> - Switched a sprintf to snprintf
> - Replaced fd == -1 check with < 0
> - Simplified switch+goto statements
Only 2 nits. Please feel free to add my R-b after fixing them (or
maybe a willing committer could fix them up when applying ;)). Thanks!
[snip]
> +static probe_ret_t
> +droid_probe_device(_EGLDisplay *disp, int fd, char *vendor)
const char *vendor
[snip]
> +static int
> +droid_open_device(_EGLDisplay *disp)
> +{
[snip]
> + int ret = droid_probe_device(disp, fd, vendor_name);
> + switch (ret) {
> + case probe_success:
> + goto success;
> + case probe_filtered_out:
> + /* Set as fallback */
> + if (fallback_fd == -1)
> + fallback_fd = fd;
> + break;
> + case probe_fail:
> + break;
> + }
> +
> + if (fallback_fd != fd)
> + close(fd);
> + fd = -1;
> + continue;
This continue doesn't do anything.
Best regards,
Tomasz
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
