On Monday, 2018-06-11 15:55:41 -0700, Dylan Baker wrote: > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 4247d195bc1..ed63276b63e 100644 > --- a/meson.build > +++ b/meson.build > @@ -699,7 +699,7 @@ if get_option('buildtype') == 'debug' > pre_args += '-DDEBUG' > endif > > -if get_option('shader-cache') > +if get_option('shader-cache') and host_machine.system() != 'windows'
This means that shader-cache=true on windows will be silently ignored, not very intuitive. How about auto/true/false, with auto = `host_machine.system() != 'windows'`? That way, patch 36/48 (meson: Don't build glsl cache_test for windows) can be guarded by `with_shader_cache` instead, which means it will be automatically tested on windows if/when turned on. > pre_args += '-DENABLE_SHADER_CACHE' > elif with_amd_vk > error('Radv requires shader cache support') > -- > 2.17.1 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev