Quoting Emil Velikov (2018-06-08 08:52:03) > On 7 June 2018 at 19:53, Dylan Baker <dy...@pnwbakers.com> wrote: > > Some of these are done already, some of them are things we're not going > > to do, like have a toggle for GLX_TLS. > > > > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> > > --- > > meson.build | 11 ----------- > > src/egl/meson.build | 2 -- > > src/gbm/meson.build | 2 -- > > 3 files changed, 15 deletions(-) > > > > diff --git a/meson.build b/meson.build > > index ff3e768362d..e47a522d6a7 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -345,7 +345,6 @@ if with_glvnd > > endif > > endif > > > > -# TODO: toggle for this > i don't see anything handling this. Am I missing something, or you > misread it as GLX_TLS?
I did misread that as GLX_TLS. Is it really an option worth having though? I
don't know of any distro that builds without direct_glx.
> > with_glx_direct = true
> >
> > if with_vulkan_icd_dir == ''
> > @@ -1207,8 +1206,6 @@ if get_option('selinux')
> > pre_args += '-DMESA_SELINUX'
> > endif
> >
> > -# TODO: llvm-prefix and llvm-shared-libs
> > -
> The meson llvm wrapper nicely handles the prefix, but I don't see it
> handling the shared/static part.
> Plus distros have both the (multiple) static and (single) shared LLVM,
> last time I've checked.
>
> Perhaps we should keep the latter TODO for now?
The LLVM dependency handler has support for linking against static-llvm since
some version (I wrote it, but I can't remember which meson release it's new in).
Like several other options in the autotools build I'd really like to see if
anyone is actually using these before we turn them on. My understanding is that
statically linking to LLVM in a shared library usually leads to pain.
Dylan
>
> With Eric's suggestions and the above nits, the series is
> Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
>
> -Emil
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
