On Wed, 7 Mar 2012 23:26:18 +0100, Marek Olšák <mar...@gmail.com> wrote: > On Wed, Mar 7, 2012 at 6:01 PM, Brian Paul <brian.e.p...@gmail.com> wrote: > > On Wed, Feb 15, 2012 at 6:28 AM, Marek Olšák <mar...@gmail.com> wrote: > >> Hi everyone, > >> > >> this series adds the ARB_debug_output extension. It implements the minimum > >> feature set required by the spec, which is GL API error logging. > >> > >> I've added a new piglit test for this: arb_debug_output-api_error. I'd > >> like to push this series in a week if there are no concerns. > >> > >> The whole series is also available here: > >> git://people.freedesktop.org/~mareko/mesa arb-debug-output > >> > >> Marek Olšák (3): > >> mesa: print GL errors via debug_output > >> mesa: display list dispatch for ARB_debug_output > >> mesa: expose ARB_debug_output > >> > >> nobled (10): > >> mesa: split error handling into its own file > >> glapi: add ARB_debug_output.xml > >> mesa: add infrastructure for GL_ARB_debug_output > >> mesa: add some GL_ARB_debug_output functions > >> mesa: add message-toggle booleans for GL_ARB_debug_output > >> mesa: add glDebugMessageControlARB > >> mesa: add yet more context fields for GL_ARB_debug_output > >> mesa: add control for categories of application-provided messages > >> mesa: add struct for managing client debug namespaces > >> mesa: implement the last of GL_ARB_debug_output > > > > Hi Marek, > > > > I did a quick read of these patches and they look OK to me. Were you > > planning on pushing them soon? > > Ian told me that he wanted to take a look at the patches and that I > should wait, therefore I didn't push them as I had planned. Ian?
I took a look at what was tested relative to the patch series. Testing I see missing: - display lists - MessageInsert - DEBUG_OUTPUT_SYNCHRONOUS_ARB - glGetPointerv() enums - API errors generated by glDebugMessageControlARB and friends. - minmax values. However, it still looks like enough testing that I'm happy to see the series go in. I don't think Ian's review should stall it at this point.
pgpDZNrDtwZMg.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
