Pushed, thanks.
Marek
On Sun, May 20, 2018 at 4:42 AM, Benedikt Schemmer <b...@besd.de> wrote:
> Hello Marek,
> thank you very much for reviewing.
>
> I don't have commit rights, could you push for me?
> (I only wrote that in the cover letter, should I put that in every patch
> in the future?)
>
> Benedikt
>
> Am 20.05.2018 um 04:58 schrieb Marek Olšák:
> > For the series:
> >
> > Reviewed-by: Marek Olšák <marek.ol...@amd.com <mailto:
> marek.ol...@amd.com>>
> >
> > Marek
> >
> >
> > On Thu, May 10, 2018 at 5:06 AM, Benedikt Schemmer <b...@besd.de <mailto:
> b...@besd.de>> wrote:
> >
> > Sometimes it is nice (and useful) to not just see if you've messed up
> > but also if you've made an improvement.
> >
> > ---
> > si-report.py | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/si-report.py b/si-report.py
> > index fba652c..d0e0686 100755
> > --- a/si-report.py
> > +++ b/si-report.py
> > @@ -686,6 +686,30 @@ def print_tables(before_all_results,
> after_all_results):
> > break
> > if num > 0:
> > print
> > +
> > + # biggest improvements
> > + metrics = si_stats().metrics
> > + for i in range(len(metrics)):
> > + field = metrics[i][0]
> > + num = 0
> > + more_is_better = metrics[i][0] == 'maxwaves'
> > +
> > + if more_is_better:
> > + sort_key = lambda v: -v[1].diff.__dict__[field]
> > + else:
> > + sort_key = lambda v: v[1].diff.__dict__[field]
> > +
> > + for name, stats in sorted(shaders.items(), key = sort_key):
> > + if more_is_better:
> > + if stats.diff.__dict__[field] <= 0:
> > + continue
> > + else:
> > + if stats.diff.__dict__[field] >= 0:
> > + continue
> > +
> > + if num == 0:
> > + print_yellow(" BIGGEST IMPROVEMENTS -
> {:64}".format(metrics[i][1]))
> > + print_yellow(" Before After Delta Percentage")
> > stats.print_regression(name, field)
> > num += 1
> > if num == num_listed:
> > --
> > 2.14.1
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org <mailto:mesa-dev@lists.
> freedesktop.org>
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev <
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
> >
> >
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
