Hi Marek,
On 2018-05-10 06:21 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.ol...@amd.com>
>
> The slot index is always 0, and is pretty unlikely to change in the future.
This change caused dozens of piglit tests to crash for me, see an
example below from tests/spec/gl-3.1/attributeless-vertexid.shader_test.
Happens both with radeonsi and llvmpipe.
Thread 1 "shader_runner" received signal SIGSEGV, Segmentation fault.
pipe_reference_described (get_desc=<optimized out>, reference=0x1e, ptr=0x0)
at ../../../../src/gallium/auxiliary/util/u_inlines.h:82
82 assert(pipe_is_referenced(reference));
(gdb) bt
#0 pipe_reference_described (get_desc=<optimized out>, reference=0x1e,
ptr=0x0) at ../../../../src/gallium/auxiliary/util/u_inlines.h:82
#1 pipe_resource_reference (tex=0x1e, ptr=0x5555559d76c0)
at ../../../../src/gallium/auxiliary/util/u_inlines.h:138
#2 pipe_vertex_buffer_reference (src=0x7fffffffd870, dst=0x5555559d76b8)
at ../../../../src/gallium/auxiliary/util/u_inlines.h:215
#3 cso_set_vertex_buffers (ctx=0x5555559d6080, start_slot=0, count=0,
buffers=0x7fffffffd870)
at ../../../../src/gallium/auxiliary/cso_cache/cso_context.c:1159
#4 0x00007ffff03833f2 in set_vertex_attribs (st=0x5555559bfe30,
st=0x5555559bfe30, num_velements=0, velements=0x7fffffffd770,
num_vbuffers=0, vbuffers=0x7fffffffd870)
at ../../../src/mesa/state_tracker/st_atom_array.c:375
#5 st_update_array (st=<optimized out>)
at ../../../src/mesa/state_tracker/st_atom_array.c:507
#6 0x00007ffff03845e2 in st_validate_state (st=st@entry=0x5555559bfe30,
pipeline=pipeline@entry=ST_PIPELINE_RENDER)
at ../../../src/mesa/state_tracker/st_atom.c:261
#7 0x00007ffff03a9d29 in prepare_draw (ctx=0x5555559a2e20,
ctx=0x5555559a2e20, st=<optimized out>)
at ../../../src/mesa/state_tracker/st_draw.c:123
#8 st_draw_vbo (ctx=0x5555559a2e20, prims=0x7fffffffdff0, nr_prims=1, ib=0x0,
index_bounds_valid=<optimized out>, min_index=<optimized out>,
max_index=<optimized out>, tfb_vertcount=0x0, stream=0, indirect=0x0)
at ../../../src/mesa/state_tracker/st_draw.c:149
#9 0x00007ffff0361d80 in vbo_draw_arrays (ctx=0x5555559a2e20, mode=6,
start=0, count=4, numInstances=1, baseInstance=0, drawID=0)
at ../../../src/mesa/vbo/vbo_exec_array.c:391
#10 0x00007ffff03627a4 in vbo_exec_DrawArrays (mode=6, start=0, count=4)
at ../../../src/mesa/vbo/vbo_exec_array.c:550
#11 0x00007ffff7a9e13b in stub_glDrawArrays (mode=6, first=0, count=4)
at tests/util/piglit-dispatch-gen.c:12150
#12 0x0000555555563367 in piglit_display ()
at tests/shaders/shader_runner.c:3137
#13 0x00007ffff7b3142d in run_test (gl_fw=0x555555783070, argc=2,
argv=0x7fffffffe658)
at tests/util/piglit-framework-gl/piglit_fbo_framework.c:52
#14 0x00007ffff7b17511 in piglit_gl_test_run (argc=2, argv=0x7fffffffe658,
config=0x7fffffffe510) at tests/util/piglit-framework-gl.c:229
#15 0x000055555555b59b in main (argc=2, argv=0x7fffffffe658)
at tests/shaders/shader_runner.c:63
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
