Hi Dave,

This commit has caused a few regressions with the vmware svga driver:

commit 72931ca4b9fb1002f5b62b74f7f7f32e94e80fde
Author: Dave Airlie <airl...@redhat.com>
Date:   Thu Feb 9 19:44:55 2012 +0000

    st/mesa: don't unreference user attribs up front.

    postpone unreferences until end of function, as the ones in use will
    get naturally dereferenced.

    Reviewed-by: Brian Paul <bri...@vmware.com>
    Signed-off-by: Dave Airlie <airl...@redhat.com>


The piglit draw-batch, quad-invariance and lodbias tests (maybe others) are failing on an assertion in the driver because the pipe->redefine_user_buffer() function isn't getting called. It seems to be caused by st->user_attrib[i].buffer being NULL where it used to be non-null before your change.

Do you mind if I just revert this for now?

-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to