On 25 April 2018 at 14:44, Juan A. Suarez Romero <jasua...@igalia.com> wrote:
> On Wed, 2018-04-25 at 13:54 +0100, Emil Velikov wrote:
>> On 24 April 2018 at 08:49, Juan A. Suarez Romero <jasua...@igalia.com> wrote:
>> > On Fri, 2018-04-20 at 16:42 +0200, Juan A. Suarez Romero wrote:
>> > > Commit fa328456e8f29 added VP9 config support, but this needs a newer
>> > > libva version, 1.7.0 or above.
>> > >
>> > > Fixes: fa328456e8f ("st/va: add VP9 config to enable profile2")
>> >
>> > Besides requesting R-B, CCing to @stable, as this fixes 18.1 build in 
>> > Travis CI.
>> >
>>
>> The Fixes should be enough but stable@ won't hurt.
>>
>> Seems like we should also bump the versions in configure.ac
>> (LIBVA_REQUIRED) and meson.build, right?
>> Can be done as a follow-up, though. As-is patch is
>
> Thing is, I did in a first version, but then I reverted that change. The 
> reason
> is that LIBVA_REQUIRED contains the expected VA API version to interact with 
> the
> library, but in this case we are not changing the functions we use, and thus 
> we
> are fine with keeping the same API version.
>
Not sure I parse this.

Obviously the difference between the tarball version and the one
advertised in the pkg-config file is a bit confusing but they both
effectively indicate the same thing.

As illustrated with this patch - we need the newer version, otherwise
it simply wont build.

Right?
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to