Hi Rob,
On Fri, Apr 20, 2018 at 6:09 AM Rob Herring <r...@kernel.org> wrote:
> Maintaining both flink names and prime fd support which are provided by
> 2 different gralloc implementations is problematic because we have a
> dependency on a specific gralloc implementation header.
> This mostly removes the dependency on the gralloc implementation and
> headers. The dependency on GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
> now, but the definition is added locally to remove the header
> dependency.
> Signed-off-by: Rob Herring <r...@kernel.org>
> ---
> With this plus Robert's probing patch, we remove any gralloc
> implementation dependency (other than it has to be a pre 1.0
> implementation...).
Big
Acked-by: Tomasz Figa <tf...@chromium.org>
from me. +/- 1 nit inline
This relic of the past should have disappeared long ago, together with all
the problems it brings. :)
[snip]
> @@ -1216,17 +1081,14 @@ dri2_initialize_android(_EGLDriver *drv,
_EGLDisplay *disp)
> /* render nodes cannot use Gem names, and thus do not support
> * the __DRI_DRI2_LOADER extension */
> if (!dri2_dpy->is_render_node) {
> - dri2_dpy->loader_extensions = droid_dri2_loader_extensions;
> - if (!dri2_load_driver(disp)) {
> - err = "DRI2: failed to load driver";
> - goto cleanup;
> - }
> - } else {
> - dri2_dpy->loader_extensions = droid_image_loader_extensions;
> - if (!dri2_load_driver_dri3(disp)) {
> - err = "DRI3: failed to load driver";
> - goto cleanup;
> - }
> + err = "DRI2: driver is not a render node";
Perhaps "device" or "handle" rather than "driver"?
Best regards,
Tomasz
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
