[Mesa-dev] [PATCH v3 067/104] nir/lower_samplers: Clean up function arguments

[Jason Ekstrand]

This little refactor makes us stop passing stage around and puts the
builder as the first parameter to some functions.
---
 src/compiler/nir/nir_lower_samplers.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/compiler/nir/nir_lower_samplers.c 
b/src/compiler/nir/nir_lower_samplers.c
index 9aa4a9e..1b243e6 100644
--- a/src/compiler/nir/nir_lower_samplers.c
+++ b/src/compiler/nir/nir_lower_samplers.c
@@ -87,8 +87,8 @@ calc_sampler_offsets(nir_deref *tail, nir_tex_instr *instr,
 }
 
 static bool
-lower_sampler(nir_tex_instr *instr, const struct gl_shader_program 
*shader_program,
-              gl_shader_stage stage, nir_builder *b)
+lower_sampler(nir_builder *b, nir_tex_instr *instr,
+              const struct gl_shader_program *shader_program)
 {
    if (instr->texture == NULL)
       return false;
@@ -117,6 +117,7 @@ lower_sampler(nir_tex_instr *instr, const struct 
gl_shader_program *shader_progr
       instr->texture_array_size = array_elements;
    }
 
+   gl_shader_stage stage = b->shader->info.stage;
    assert(location < shader_program->data->NumUniformStorage &&
           shader_program->data->UniformStorage[location].opaque[stage].active);
 
@@ -131,8 +132,8 @@ lower_sampler(nir_tex_instr *instr, const struct 
gl_shader_program *shader_progr
 }
 
 static bool
-lower_impl(nir_function_impl *impl, const struct gl_shader_program 
*shader_program,
-           gl_shader_stage stage)
+lower_impl(nir_function_impl *impl,
+           const struct gl_shader_program *shader_program)
 {
    nir_builder b;
    nir_builder_init(&b, impl);
@@ -141,8 +142,8 @@ lower_impl(nir_function_impl *impl, const struct 
gl_shader_program *shader_progr
    nir_foreach_block(block, impl) {
       nir_foreach_instr(instr, block) {
          if (instr->type == nir_instr_type_tex)
-            progress |= lower_sampler(nir_instr_as_tex(instr),
-                                      shader_program, stage, &b);
+            progress |= lower_sampler(&b, nir_instr_as_tex(instr),
+                                      shader_program);
       }
    }
 
@@ -157,8 +158,7 @@ nir_lower_samplers(nir_shader *shader,
 
    nir_foreach_function(function, shader) {
       if (function->impl)
-         progress |= lower_impl(function->impl, shader_program,
-                                shader->info.stage);
+         progress |= lower_impl(function->impl, shader_program);
    }
 
    return progress;
-- 
2.5.0.400.gff86faf

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev