Hi Brian, On 29 March 2018 at 02:48, Brian Paul <bri...@vmware.com> wrote: > Silence a gcc warning about missing return value in non-void function. > For some reason, gcc 5.4.0 (at least) can't deduce that all else/if > cases return a value.
A small brain dump: Guessing that's because of the unreachable() cases at the end of the if (a->file == IMM) branch. Ideally we'll update the macro to make things more obvious for the compiler. Otherwise we'll have to update dozens of similar instances through the code base. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
