Quoting Sergii Romantsov (2018-03-26 14:11:26) > Hello, Chris. Thank you for reviewing patch. > Do you mean changing just only emit_reloc() parameter type or all the > preceding > callers too?
If you insist, but you don't have to. int32_t on the parameter is enough to document and correct the type. Propagating it through to all callers can be left for another day. > Also, please, explain what you mean about patch cee9f3890351? > That issue is present even on mesa 13-0.0 and also solved with similar > type-conversion fix. Hmm. I was thinking that if we only assigned 32b addresses the wrap would be ok; but no, it's only ok if the kernel does the relocation. -Chris _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
