Hi Emil, On Wed, Mar 21, 2018 at 5:09 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Maxin, > > Welcome back ;-)
Thanks :) > > On 21 March 2018 at 14:52, <maxin.j...@gmail.com> wrote: >> From: Khem Raj <raj.k...@gmail.com> >> >> endianness check is OS wide and not specific to libc. >> Fixes build with musl libc >> >> Signed-off-by: Khem Raj <raj.k...@gmail.com> >> Signed-off-by: Maxin B. John <maxin.j...@intel.com> >> --- >> src/util/u_endian.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/util/u_endian.h b/src/util/u_endian.h >> index 22d011e..4d5b4f4 100644 >> --- a/src/util/u_endian.h >> +++ b/src/util/u_endian.h >> @@ -27,7 +27,7 @@ >> #ifndef U_ENDIAN_H >> #define U_ENDIAN_H >> >> -#if defined(__GLIBC__) || defined(ANDROID) || defined(__CYGWIN__) >> +#if defined(__linux__) > > Fairly sure that glibc, musl and android define __linux__, although > I'm having doubts about Cygwin. > Which platforms did you test this patch on? This patch was tested on glibc and musl based systems with OpenEmbedded. Haven't build tested on android, although checked with # aarch64-linux-android-cpp -dM < /dev/null | grep __linux__ #define __linux__ 1 > Jon, will this confirm if this will work on your end, or we'll need to > add the __CYGWIN__ hunk back? will update the CYGWIN part based on Jon's feedback. > Thanks > Emil Best Regards, Maxin _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
