Sent from my iPhone...
> On Mar 14, 2018, at 16:41, Matt Turner <matts...@gmail.com> wrote: > > Subject should have a swr prefix or similar. > > On Wed, Mar 14, 2018 at 4:19 PM, Jeremy Huddleston Sequoia > <jerem...@apple.com> wrote: >> From: Apple SWE <jerem...@apple.com> > > Explain? I didn’t author it. Author is an Apple Employee in SWE who does not want attribution. > >> >> The implementation for bootstrapping SWR on Darwin targets is based on the >> Linux version. >> Instead of reading the output of /proc/cpuinfo, sysctlbyname is used to >> determine the >> physical identifiers, processor identifiers, core counts and >> thread-processor affinities. >> >> With this patch, it is possible to use SWR as an alternate renderer on OSX >> to softpipe and >> llvmpipe. > > All of these look like they're too long to fix in 80 columns in git show. > >> Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > > I'm guessing you're just pushing code someone else wrote... > >> Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > > We don't have a DCO, so Signed-off-by has no meaning. Worse, in the > case we added a DCO in the future, all of the stupid Signed-off-by's > people have been cargo culting for years would confuse everything. > Please stop doing it. Ok. I’ll remove it. > > Please don't push code to maintained drivers without going through the > mailing list. I feel like I shouldn't have to say that. In the past there hasn’t been much care about code in __APPLE__, so I figured it want that big of a deal, but if you are interested in reviewing these changes, that’s great to hear. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
